Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Consider external networks for VM scheduling
......................................................................
engine: Consider external networks for VM scheduling
External networks are assumed to be present in the entire cluster that
they're attached to, so if an external network is attached to a vNIC it
shouldn't be required by the scheduler.
Change-Id: I0ea9bf9fadfa9954ee856a38779ed5a627c6165f
Signed-off-by: Mike Kolesnik <mkole...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java
1 file changed, 8 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/45/21245/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java
index a0e0498..2f58993 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java
@@ -117,13 +117,16 @@
private boolean networkRequiredOnVds(VmNetworkInterface vmIface,
Map<String, Network> networksByName,
boolean onlyRequiredNetworks) {
- boolean networkRequiredOnVds = true;
if (!vmIface.isPlugged()) {
- networkRequiredOnVds = false;
- } else if (onlyRequiredNetworks) {
- networkRequiredOnVds =
networksByName.get(vmIface.getNetworkName()).getCluster().isRequired();
+ return false;
}
- return networkRequiredOnVds;
+
+ Network network = networksByName.get(vmIface.getNetworkName());
+ if (onlyRequiredNetworks) {
+ return network.getCluster().isRequired();
+ }
+
+ return !network.isExternal();
}
/**
--
To view, visit http://gerrit.ovirt.org/21245
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ea9bf9fadfa9954ee856a38779ed5a627c6165f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkole...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
