Ori Liel has posted comments on this change.
Change subject: restapi: Add Reboot support
......................................................................
Patch Set 15:
(1 comment)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 2269: <xs:sequence>
Line 2270: <xs:element name="enabled" type="xs:boolean" minOccurs="0"
maxOccurs="1"/>
Line 2271: <xs:element name="priority" type="xs:int" minOccurs="0"
maxOccurs="1"/>
Line 2272: <xs:element name="powerdown_forced" type="xs:boolean"
minOccurs="0" maxOccurs="1" />
Line 2273: <xs:element name="graceful_timeout" type="xs:int"
minOccurs="0" maxOccurs="1" />
There is an element in our schema called: "GracePeriod". This is how it's
defined (pasted from api.xsd):
<xs:complexType name="GracePeriod">
<xs:sequence>
<xs:element name="expiry" type="xs:long"/>
</xs:sequence>
</xs:complexType>
Michael's comment from a few patches ago suggested to use a reference to this
element here instead of the 'graceful_timeout'. It would look like this:
<xs:element name="grace_period" type="GracePeriod" minOccurs="0"/>
I didn't understand from your comments on this suggestion if you're against the
idea, and in that case, for what reason.
Line 2274: </xs:sequence>
Line 2275: </xs:complexType>
Line 2276:
Line 2277: <xs:element name="display" type="Display"/>
--
To view, visit http://gerrit.ovirt.org/16194
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9a5007a1364392830e4112e57ec54a7025fee02
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Martin Betak <mbe...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
