Sandro Bonazzola has posted comments on this change.

Change subject: Add new job update-engine-params
......................................................................


Patch Set 24:

(4 comments)

....................................................
File jobs/ovirt_engine_upgrade_params/update_engine_params.sh
Line 28:        if ! rpm -q postgresql-server; then
Line 29:                yum -y install postgresql-server
Line 30:        fi
Line 31: 
Line 32:        systemctl stop postgresql.service
you can use service postgresql stop here, it works both on fedora and centos.
Line 33:        rm -rf /var/lib/pgsql/data
Line 34:        postgresql-setup initdb || res=$(($res + $?))
Line 35:        systemctl start postgresql.service || res=$(($res + $?))
Line 36:        if [[ "${res}" -ne 0 ]]; then


Line 31: 
Line 32:        systemctl stop postgresql.service
Line 33:        rm -rf /var/lib/pgsql/data
Line 34:        postgresql-setup initdb || res=$(($res + $?))
Line 35:        systemctl start postgresql.service || res=$(($res + $?))
you can use service postgresql start here, it works both on fedora and centos.
Line 36:        if [[ "${res}" -ne 0 ]]; then
Line 37:                echo "Failed to init postgres"
Line 38:                exit 1
Line 39:        fi


Line 71: 
Line 72: configure_from_repo()
Line 73: {
Line 74:        if [[ "${FROM}" == "stable" ]]; then
Line 75:                cat << "EOF" > 
/etc/yum.repos.d/upgrade_params_${FROM}.repo
you can check on /etc/fedora-release for discovering if you're on Fedora and 
use this repo or use centos repo.
Line 76: [ovirt-engine-stable]
Line 77: name=oVirt Engine Stable
Line 78: baseurl=http://ovirt.org/releases/stable/rpm/Fedora/$releasever/
Line 79: enabled=1


Line 119: }
Line 120: 
Line 121: 
Line 122: configure_to_repo()
Line 123: {
you can check on /etc/fedora-release for discovering if you're on Fedora and 
use this repo or use centos repo.
Line 124:       if [[ "${TO}" == "nightly" ]]; then
Line 125:               cat << "EOF" > 
/etc/yum.repos.d/upgrade_params_${TO}.repo
Line 126: [ovirt-engine-nightly]
Line 127: name=oVirt Engine Nightly


-- 
To view, visit http://gerrit.ovirt.org/21094
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1809bd55c88b17f1d7dfde3920212e6f046709a8
Gerrit-PatchSet: 24
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ew...@kohlvanwijngaarden.nl>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com>
Gerrit-Reviewer: Ohad Basan <oba...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to