Alon Bar-Lev has uploaded a new change for review.
Change subject: bll: GetServerSSHKeyFingerprintQueryTest: cleanup: remove
doNothing
......................................................................
bll: GetServerSSHKeyFingerprintQueryTest: cleanup: remove doNothing
less complexity and one less false positive at coverity.
Change-Id: Id602ca76e1069d794750789c0e2283c22639139e
Signed-off-by: Alon Bar-Lev <alo...@redhat.com>
---
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetServerSSHKeyFingerprintQueryTest.java
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/93/21193/1
diff --git
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetServerSSHKeyFingerprintQueryTest.java
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetServerSSHKeyFingerprintQueryTest.java
index fcb9335..02afc1e 100644
---
a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetServerSSHKeyFingerprintQueryTest.java
+++
b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetServerSSHKeyFingerprintQueryTest.java
@@ -9,7 +9,6 @@
import org.junit.Before;
import org.junit.Test;
-import static org.mockito.Mockito.doNothing;
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;
@@ -26,8 +25,6 @@
private void setupMock() throws Exception {
mockEngineSSHClient = mock(EngineSSHClient.class);
- doNothing().when(mockEngineSSHClient).connect();
- doNothing().when(mockEngineSSHClient).authenticate();
doReturn(mockEngineSSHClient).when(getQuery()).getEngineSSHClient();
}
--
To view, visit http://gerrit.ovirt.org/21193
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id602ca76e1069d794750789c0e2283c22639139e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
