Adam Litke has posted comments on this change.

Change subject: Add support for optional collector fields and (null expr) test
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

Just a small housekeeping change and this will be ready.

....................................................
File mom/Policy/Parser.py
Line 304:                     '<=': 'lte', '>=': 'gte',
Line 305:                     '<<': 'shl', '>>': 'shr',
Line 306:                     '==': 'eq', '!=': 'neq',
Line 307:                     'and': 'and', 'or': 'or', 'not': 'not',
Line 308:                     'min': 'min', 'max': 'max', "valid": "valid" }
We need to remove this now since we are not going to use it.
Line 309: 
Line 310:     def __init__(self):
Line 311:         GenericEvaluator.__init__(self)
Line 312:         self.stack = VariableStack()


-- 
To view, visit http://gerrit.ovirt.org/21050
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a93f0985870b431c315918b14fee6629eac70fb
Gerrit-PatchSet: 3
Gerrit-Project: mom
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Adam Litke <a...@us.ibm.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to