Sahina Bose has posted comments on this change.
Change subject: restapi: Commit remove brick if migrate executed
......................................................................
Patch Set 3:
(4 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommand.java
Line 60: (getGlusterVolume().getVolumeType() ==
GlusterVolumeType.REPLICATE
Line 61: || getGlusterVolume().getVolumeType() ==
GlusterVolumeType.DISTRIBUTED_REPLICATE)
Line 62: ? getParameters().getReplicaCount()
Line 63: : 0;
Line 64:
You can remove this line to reduce noise on patch
Line 65: VDSReturnValue returnValue =
Line 66: runVdsCommand(
Line 67: VDSCommandType.StartRemoveGlusterVolumeBricks,
Line 68: new
GlusterVolumeRemoveBricksVDSParameters(upServer.getId(),
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterBricksResource.java
Line 59:
Line 60: @SuppressWarnings("unchecked")
Line 61: @Override
Line 62: public GlusterBricks list() {
Line 63: boolean flag = QueryHelper.hasMatrixParam(getUriInfo(),
"force");
remove above line
Line 64: List<GlusterBrickEntity> bricks =
Line 65:
getBackendCollection(VdcQueryType.GetGlusterVolumeBricks, new
IdQueryParameters(asGuid(getVolumeId())));
Line 66: GlusterBricks bricksModel = mapCollection(bricks);
Line 67: return addActions(bricksModel);
Line 186: // return
performAction(VdcActionType.CommitRemoveGlusterVolumeBricks, params);
Line 187: // }
Line 188: }
Line 189:
Line 190: private boolean isForceRemove() {
remove this.
Line 191: String value = QueryHelper.getMatrixConstraint(getUriInfo(),
"force");
Line 192: if (value == null) {
Line 193: return true;
Line 194: } else {
Line 253:
Line 254: }
Line 255:
Line 256: private GlusterVolumeRemoveBricksParameters toParameters(Action
action) {
Line 257: return toParameters(action.getBricks());
remove this
Line 258: }
Line 259:
Line 260: private GlusterVolumeRemoveBricksParameters
toParameters(GlusterBricks bricks) {
Line 261: GlusterVolumeRemoveBricksParameters params = new
GlusterVolumeRemoveBricksParameters();
--
To view, visit http://gerrit.ovirt.org/21043
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7830749bb84f61dd1a80281d3abe6dc113150fd1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
