Alon Bar-Lev has posted comments on this change. Change subject: packaging: pep8. ......................................................................
Patch Set 3: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/config/domain_type.py Line 65: ), Line 66: condition=lambda self: ( Line 67: self.environment[osetupcons.DBEnv.NEW_DATABASE] and Line 68: self.environment[osetupcons.ConfigEnv.APPLICATION_MODE] Line 69: != 'gluster' thanks! should be: self.environment[ osetupcons.ConfigEnv.APPLICATION_MODE ] != 'gluster' Line 70: ), Line 71: ) Line 72: def _customization(self): Line 73: self._enabled = True -- To view, visit http://gerrit.ovirt.org/21156 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia45407f438bfa147c3350f3ed30342bd1c493b52 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Darshan N <dnara...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches