Alon Bar-Lev has uploaded a new change for review.
Change subject: services: pki-resource: send proper http code when exception
......................................................................
services: pki-resource: send proper http code when exception
open writer only after validations.
Change-Id: Idf4c5157bf7425da5f9bb0d5186c48b4b9cc313c
Signed-off-by: Alon Bar-Lev <alo...@redhat.com>
---
M
backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/33/21133/1
diff --git
a/backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java
b/backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java
index 6fa2700..4d1dcde 100644
---
a/backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java
+++
b/backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/PKIResourceServlet.java
@@ -59,7 +59,7 @@
String format = getMyParameter("format", request);
String alias = getMyParameter("alias", request);
- try (PrintWriter out = response.getWriter()) {
+ try {
if (resource == null) {
throw new IllegalArgumentException("Missing resource name");
}
@@ -76,8 +76,10 @@
}
}
- response.setContentType(pkiResources.getContentType(r,
outputType));
- out.print(pkiResources.getAsString(r, outputType, alias));
+ try (PrintWriter out = response.getWriter()) {
+ response.setContentType(pkiResources.getContentType(r,
outputType));
+ out.print(pkiResources.getAsString(r, outputType, alias));
+ }
}
catch(Exception e) {
log.error(
--
To view, visit http://gerrit.ovirt.org/21133
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idf4c5157bf7425da5f9bb0d5186c48b4b9cc313c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
