Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Changed by reference check to by value (findbugs) ......................................................................
webadmin: Changed by reference check to by value (findbugs) When setting a model's change prohibition reason, the check whether the value is different than the preceding value, in order to see if an event has to be raised, was being done by reference rather than by value. It doesn't really matter because all strings passed to the method are constants, but the norm with triggering value change events is to check by value. Change-Id: Ibca529d23718dfaa5bf120d0bc157c259f016911 Signed-off-by: Lior Vernia <lver...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Lior Vernia: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/21091 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibca529d23718dfaa5bf120d0bc157c259f016911 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
