Liron Ar has posted comments on this change. Change subject: backend, restapi: Add read-only disk functionality ......................................................................
Patch Set 17: (1 comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java Line 266: && bootOrder == other.bootOrder Line 267: && ObjectUtils.objectsEqual(specParams, other.specParams) Line 268: && isManaged == other.isManaged Line 269: && getIsPlugged().equals(other.getIsPlugged()) Line 270: && getIsReadOnly().equals(other.getIsReadOnly()) I still don't agree about that one. Line 271: && alias.equals(other.alias) Line 272: && ObjectUtils.objectsEqual(customProperties, other.customProperties) Line 273: && ObjectUtils.objectsEqual(snapshotId, other.snapshotId)); Line 274: } -- To view, visit http://gerrit.ovirt.org/15409 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I124176e8feb91b601a71e76dd63051648ec4353a Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
