Daniel Erez has posted comments on this change.
Change subject: webadmin: Disable Host/Interfaces subtab refresh pre-3.1
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceListModel.java
Line 2258:
Line 2259: setSelectionAvailable(isLessThan31);
Line 2260:
Line 2261: // disable subtab refresh for pre-3.1 clusters, to avoid
interfering with row selection
Line 2262: setIsTimerDisabled(isLessThan31);
Not sure if it's worth the trouble to fix it for legacy versions. The default
behavior should be automatic refresh without a refresh button (unless there's
some other issue with the refresh..). See if you can show/hide the refresh
button from the sub-tab view 'setMainTabSelectedItem' (in which the main-tab
entity should be available).
Line 2263: if (isLessThan31) {
Line 2264: stopRefresh();
Line 2265: }
Line 2266: }
--
To view, visit http://gerrit.ovirt.org/21031
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb1d14be079936eac2fb302320eb7000e970bc32
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
