Allon Mureinik has posted comments on this change.

Change subject: backend: unlock images when GetImageInfo fails
......................................................................


Patch Set 3:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
Line 327:                         newImageId, newImageGroupId, 
newStorageDomainID);
Line 328:             } finally {
Line 329:                 // Unlock destination image:
Line 330:                 
getDestinationDiskImage().setImageStatus(ImageStatus.OK);
Line 331:                 
getImageDao().update(getDestinationDiskImage().getImage());
It is locked during the execute - you'd want to unlock it :-)
Line 332:             }
Line 333:         }
Line 334: 
Line 335:         unLockImage();


-- 
To view, visit http://gerrit.ovirt.org/20669
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I980e60ba5ad4fcc07752d065c3eaca03af025896
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to