Liran Zelkha has posted comments on this change. Change subject: core: Automatic login filter ......................................................................
Patch Set 1: Code-Review+1 (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutomaticLoginFilter.java Line 145: boolean isAdmin = MultiLevelAdministrationHandler.isAdminUser(dbUser); Line 146: dbUser.setAdmin(isAdmin); Line 147: Line 148: // Attach the user to the session: Line 149: SessionDataContainer.getInstance().setUser(req.getSession().getId(), dbUser); For performance benefits - wouldn't loading all the user permissions at login and storing them at the session be better? Line 150: Line 151: // Forward the request to the next filter in the chain: Line 152: chain.doFilter(req, rsp); Line 153: } -- To view, visit http://gerrit.ovirt.org/21023 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b8cbee89b5bb96271c3706e9e75acbf2890a0b8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
