Ravi Nori has posted comments on this change.
Change subject: engine : Remove StopVmParameters from StopVmCommand
......................................................................
Patch Set 12:
(1 comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmVdcParameter.java
Line 4: import org.ovirt.engine.core.compat.Guid;
Line 5:
Line 6: public class VmVdcParameter {
Line 7:
Line 8: public static final VdcParameter StopVmType =
VdcParameter.create("StopVmType", StopVmTypeEnum.class,
"20000000-0000-0000-0000-000000000001");
In the current design there is nothing that stops the user from doing this, I
did this in junit test I had written in patch set #1. Not ideal but given the
plugin use case this can't be avoided.
Line 9: public static final VdcParameter VmId = VdcParameter.create("VmId",
Guid.class, "20000000-0000-0000-0000-000000000002");
Line 10:
--
To view, visit http://gerrit.ovirt.org/20479
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I404816e3e70ce044e1348af0eeea18b59e521581
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
