Alon Bar-Lev has posted comments on this change.
Change subject: engine: Add infrastructure code for removal of parameter classes
......................................................................
Patch Set 12:
(2 comments)
....................................................
File backend/manager/modules/common/pom.xml
Line 50: <groupId>org.springframework</groupId>
Line 51: <artifactId>spring-core</artifactId>
Line 52: <version>3.2.4.RELEASE</version>
Line 53: <type>jar</type>
Line 54: </dependency>
why do we need spring-core? I do not see it being used.
Line 55: </dependencies>
Line 56:
Line 57: <build>
Line 58: <plugins>
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VdcParameter.java
Line 2:
Line 3: import java.io.Serializable;
Line 4: import java.util.HashMap;
Line 5: import java.util.Map;
Line 6: import org.ovirt.engine.core.compat.Guid;
we want to kill compat, why have you used it and not standard java guid?
Line 7:
Line 8: public class VdcParameter implements Serializable {
Line 9:
Line 10: private final String name;
--
To view, visit http://gerrit.ovirt.org/20414
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a0970e492c0eff561888a46b02e47645ff68fc3
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
