Hello Alon Bar-Lev, Kanagaraj M, Sahina Bose,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/21067
to review the following change.
Change subject: gluster: set brick status as volume status
......................................................................
gluster: set brick status as volume status
In gluster sync job, after volume information are synced, brick status
of new volumes are set to down state. Whereas brick statuses are
synced by another thread which updates later. This gives unpleasant
user experience.
This is fixed by setting brick status as volume status for new
volumes.
Change-Id: Idab3fd6c7d44a2e7a557bcf1e759dcb969a43374
Signed-off-by: Bala.FA <barum...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/67/21067/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
index 58dfd21..9b303d0 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java
@@ -455,6 +455,11 @@
volume.getName());
return;
}
+
+ // Set initial brick status as similar to volume status.
+ // As actual brick status is updated by another sync job,
+ // till it happens, this gives better UI experience
+ brick.setStatus(volume.getStatus());
}
logUtil.logVolumeMessage(volume,
AuditLogType.GLUSTER_VOLUME_CREATED_FROM_CLI);
--
To view, visit http://gerrit.ovirt.org/21067
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idab3fd6c7d44a2e7a557bcf1e759dcb969a43374
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <barum...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
