Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: update psql version detection
......................................................................


Patch Set 2: Verified-1

(1 comment)

....................................................
File packaging/common_utils.py
Line 851:             )
Line 852:         createDatabase(db_dict['dbname'], db_dict['username'])
Line 853: 
Line 854: 
Line 855: def createLang(db_dict, TEMP_PGPASS):
Try with:
  import distutils.version
  minimal = distutils.version.LooseVersion('9.2.0')
  current = distutils.version.LooseVersion(
      runPostgresSuQuery('"show server_version;"')[0].strip()
  )
  if current > minimal:
     ....
Line 856:     if runPostgresSuQuery('"show server_version;"')[0].strip() > 
'9.2.0':
Line 857:         logging.debug(
Line 858:             'PSQL version is higher than 9.2, '
Line 859:             'no need to createlang'


-- 
To view, visit http://gerrit.ovirt.org/20997
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I17c11b9a99a3f2d56e9a27596bc822663bf2380d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to