Sahina Bose has posted comments on this change.
Change subject: gluster: Refactored GlusterTaskSyncJob
......................................................................
Patch Set 1:
(3 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StopRebalanceGlusterVolumeCommand.java
Line 85: return errorType == null ?
AuditLogType.GLUSTER_VOLUME_REBALANCE_STOP_FAILED : errorType;
Line 86: }
Line 87: }
Line 88:
Line 89: public GlusterTaskUtils getGlusterTaskUtils() {
move this to base class
Line 90: return GlusterTaskUtils.getInstance();
Line 91: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTaskUtils.java
Line 43:
Line 44: private static final Log log =
LogFactory.getLog(GlusterTasksSyncJob.class);
Line 45:
Line 46: protected GlusterTaskUtils() {
Line 47: }
private ?
Line 48:
Line 49: public static GlusterTaskUtils getInstance() {
Line 50: if (instance == null) {
Line 51: instance = new GlusterTaskUtils();
Line 142:
Line 143: return ExecutionMessageDirector.resolveStepMessage(stepType,
values);
Line 144: }
Line 145:
Line 146: public Map<String, String> getMessageMap(VDSGroup cluster,
GlusterAsyncTask task) {
Does it need to be public? Would be used only by updateStep method, rt?
Line 147: Map<String, String> values = new HashMap<String, String>();
Line 148: values.put(GlusterConstants.CLUSTER, cluster.getName());
Line 149: values.put(GlusterConstants.VOLUME,
task.getTaskParameters().getVolumeName());
Line 150: String jobStatus = getJobStatusInfo(task);
--
To view, visit http://gerrit.ovirt.org/21063
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1abecae9389530324154cdc059ee717db0a61715
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
