Alon Bar-Lev has posted comments on this change.
Change subject: engine: Add infrastructure code for removal of parameter classes
......................................................................
Patch Set 8:
(3 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VdcParameter.java
Line 52:
Line 53: @Override
Line 54: public String toString() {
Line 55: return getName() + ";" + getJavaType().getName() + ";" +
guid.toString();
Line 56: }
question: are we forced to use the toString() as serialization?
if not, I prefer two methods: serialize() and deserialize(s) instead of
asymmetric toString() and getValue(s)
Line 57:
Line 58: public static VdcParameter create(String name, Class javaType,
String guidStr) {
Line 59: Guid guid = new Guid(guidStr);
Line 60: if (parametersMap.containsKey(guid)) {
Line 60: if (parametersMap.containsKey(guid)) {
Line 61: throw new InvalidParameterGuidException(name, guidStr,
parametersMap.get(guid));
Line 62: }
Line 63: parametersMap.put(guid, new VdcParameter(name, javaType,
guid));
Line 64: return parametersMap.get(guid);
why don't you keep the new VdcParameter() in a variable and return it instead
of going via the map again?
Line 65: }
Line 66:
Line 67: /**
Line 68: * Used by Json deserializer to retrieve the existing VdcParameter
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VdcParametersMap.java
Line 4: import java.util.HashMap;
Line 5: import java.util.Map;
Line 6: import java.util.Map.Entry;
Line 7:
Line 8: public class VdcParametersMap implements Serializable {
support clonable?
Line 9:
Line 10: private Map<VdcParameter, Object> paramsMap;
Line 11:
Line 12: public VdcParametersMap() {
--
To view, visit http://gerrit.ovirt.org/20414
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a0970e492c0eff561888a46b02e47645ff68fc3
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
