Alon Bar-Lev has posted comments on this change.
Change subject: core: Add authentication module
......................................................................
Patch Set 1:
(3 comments)
....................................................
File
backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/nop/NopDirectory.java
Line 6:
Line 7: import org.ovirt.engine.core.authentication.Directory;
Line 8: import org.ovirt.engine.core.authentication.DirectoryGroup;
Line 9: import org.ovirt.engine.core.authentication.DirectoryUser;
Line 10: import org.ovirt.engine.core.common.utils.ExternalId;
please do not leak utils into plugin interface.
Line 11:
Line 12: public class NopDirectory implements Directory {
Line 13: // The name of the directory:
Line 14: private String name;
....................................................
File
backend/manager/modules/authentication/src/main/modules/org/ovirt/engine/core/authentication/main/module.xml
Line 9: <dependencies>
Line 10: <module name="javax.api"/>
Line 11: <module name="javax.servlet.api"/>
Line 12: <module name="org.apache.commons.lang"/>
Line 13: <module name="org.ovirt.engine.core.common"/>
please separate all reusable interface into own module so we can publish these
without be dependent on engine version.
we should also reduce the usage of implementations within the published
interfaces in favor of simple primitive types such as list and map so that we
may support forward compatibility.
Line 14: <module name="org.slf4j"/>
Line 15: </dependencies>
Line 16:
....................................................
File ovirt-engine.spec.in
Line 716: %ghost %config(noreplace) %{engine_etc}/engine.conf
Line 717: %{engine_data}/branding/ovirt.brand/
Line 718: %{engine_etc}/branding/00-ovirt.brand
Line 719: %{engine_etc}/engine.conf.d/
Line 720: %{engine_java}/authentication.jar
not sure why this cannot be left at engine directory as it is not actually
reusable, right?
Line 721: %{engine_java}/common.jar
Line 722: %{engine_java}/compat.jar
Line 723: %{engine_java}/utils.jar
Line 724:
--
To view, visit http://gerrit.ovirt.org/21027
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I79ff506bfca42d90a1fbaa7d9bfa8b0c4c140dff
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
