Alissa Bonas has uploaded a new change for review. Change subject: core: rename methods to lowercase in tags class ......................................................................
core: rename methods to lowercase in tags class Change-Id: I2653dddc6b9d633346fb1b1dc6915243191ac66d Signed-off-by: Alissa Bonas <abo...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/tags.java 2 files changed, 17 insertions(+), 17 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/19/21019/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java index e06385a..0d4daaa 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TagsDirector.java @@ -258,20 +258,20 @@ if (tag == null) { return StringUtils.EMPTY; } - StringBuilder sb = tag.GetTagIdAndChildrenIds(); + StringBuilder sb = tag.getTagIdAndChildrenIds(); return sb.toString(); } public String GetTagNameAndChildrenNames(Guid tagId) { tags tag = GetTagById(tagId); - StringBuilder sb = tag.GetTagNameAndChildrenNames(); + StringBuilder sb = tag.getTagNameAndChildrenNames(); return sb.toString(); } public java.util.HashSet<Guid> GetTagIdAndChildrenIdsAsSet(Guid tagId) { tags tag = GetTagById(tagId); java.util.HashSet<Guid> set = new java.util.HashSet<Guid>(); - tag.GetTagIdAndChildrenIdsAsList(set); + tag.getTagIdAndChildrenIdsAsList(set); return set; } @@ -286,7 +286,7 @@ */ public String GetTagIdAndChildrenIds(String tagName) { tags tag = GetTagByName(tagName); - StringBuilder sb = tag.GetTagIdAndChildrenIds(); + StringBuilder sb = tag.getTagIdAndChildrenIds(); return sb.toString(); } @@ -314,14 +314,14 @@ { if (sb.length() == 0) { if (indicator == TagReturnValueIndicator.ID) - sb.append(child.GetTagIdAndChildrenIds()); + sb.append(child.getTagIdAndChildrenIds()); else - sb.append(child.GetTagNameAndChildrenNames()); + sb.append(child.getTagNameAndChildrenNames()); } else { if (indicator == TagReturnValueIndicator.ID) - sb.append(String.format(",%1$s", child.GetTagIdAndChildrenIds())); + sb.append(String.format(",%1$s", child.getTagIdAndChildrenIds())); else - sb.append(String.format(",%1$s", child.GetTagNameAndChildrenNames())); + sb.append(String.format(",%1$s", child.getTagNameAndChildrenNames())); } } else { RecursiveGetTagsAndChildrenByRegExp(tagNameRegExp, sb, child, indicator); diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/tags.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/tags.java index 395160e..cd0c091 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/tags.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/tags.java @@ -135,41 +135,41 @@ _children = children; } - public StringBuilder GetTagIdAndChildrenIds() { + public StringBuilder getTagIdAndChildrenIds() { StringBuilder builder = new StringBuilder(); builder.append("'").append(gettag_id()).append("'"); for (tags tag : _children) { - builder.append(",").append(tag.GetTagIdAndChildrenIds()); + builder.append(",").append(tag.getTagIdAndChildrenIds()); } return builder; } - public StringBuilder GetTagNameAndChildrenNames() { + public StringBuilder getTagNameAndChildrenNames() { StringBuilder builder = new StringBuilder(); builder.append("'").append(gettag_name()).append("'"); for (tags tag : _children) { - builder.append("," + tag.GetTagNameAndChildrenNames()); + builder.append("," + tag.getTagNameAndChildrenNames()); } return builder; } - public void GetTagIdAndChildrenIdsAsList(java.util.HashSet<Guid> tagIds) { + public void getTagIdAndChildrenIdsAsList(java.util.HashSet<Guid> tagIds) { tagIds.add(gettag_id()); for (tags tag : _children) { - tag.GetTagIdAndChildrenIdsAsList(tagIds); + tag.getTagIdAndChildrenIdsAsList(tagIds); } } - public void GetTagIdAndChildrenNamesAsList(java.util.HashSet<String> tagIds) { + public void getTagIdAndChildrenNamesAsList(java.util.HashSet<String> tagIds) { tagIds.add(gettag_name()); for (tags tag : _children) { - tag.GetTagIdAndChildrenNamesAsList(tagIds); + tag.getTagIdAndChildrenNamesAsList(tagIds); } } - public void UpdateTag(tags from) { + public void updateTag(tags from) { setdescription(from.getdescription()); settag_name(from.gettag_name()); } -- To view, visit http://gerrit.ovirt.org/21019 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2653dddc6b9d633346fb1b1dc6915243191ac66d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches