Tal Nisan has posted comments on this change.

Change subject: core: rename methods to lowercase in VdcEventNotificationUtils
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java
Line 139:      * @param type
Line 140:      *            The type.
Line 141:      * @return
Line 142:      */
Line 143:     public static Map<EventNotificationEntity, HashSet<AuditLogType>> 
getNotificationEventsByType(
This one seems unused, you can remove it in a different patch set
Line 144:             EventNotificationEntity type) {
Line 145:         Map<EventNotificationEntity, HashSet<AuditLogType>> map =
Line 146:                 new HashMap<EventNotificationEntity, 
HashSet<AuditLogType>>();
Line 147:         if (_eventNotificationTypeMap.containsKey(type)) {


-- 
To view, visit http://gerrit.ovirt.org/21012
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15a6ac6cca84e6498d8336bf8ea57e9f97b63dac
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to