Douglas Schilling Landgraf has uploaded a new change for review. Change subject: engine_page: valid.Empty() handling None ......................................................................
engine_page: valid.Empty() handling None On update() we should validate None as well. Change-Id: Ia0d9e94c719bac40d6adb4e4939e3c2cfcec6fe8 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1019884 Signed-off-by: Douglas Schilling Landgraf <dougsl...@redhat.com> --- M src/engine_page.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-node-plugin-vdsm refs/changes/98/20998/1 diff --git a/src/engine_page.py b/src/engine_page.py index 481a2f9..1fc238e 100644 --- a/src/engine_page.py +++ b/src/engine_page.py @@ -284,8 +284,8 @@ @NodeConfigFileSection.map_and_update_defaults_decorator def update(self, server, port, cert_path): - (valid.Empty() | valid.FQDNOrIPAddress())(server) - (valid.Empty() | valid.Port())(port) + (valid.Empty(or_none=True) | valid.FQDNOrIPAddress())(server) + (valid.Empty(or_none=True) | valid.Port())(port) class SetRootPassword(utils.Transaction.Element): -- To view, visit http://gerrit.ovirt.org/20998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia0d9e94c719bac40d6adb4e4939e3c2cfcec6fe8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-node-plugin-vdsm Gerrit-Branch: node-3.0 Gerrit-Owner: Douglas Schilling Landgraf <dougsl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
