Alissa Bonas has uploaded a new change for review.
Change subject: core: rename methods in GetDeviceListVDSCommand to lowercase
......................................................................
core: rename methods in GetDeviceListVDSCommand to lowercase
Change-Id: Icff34cd6a37ec92681547398839da8b8ce2e66b6
Signed-off-by: Alissa Bonas <abo...@redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVGInfoVDSCommand.java
M
backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommandTest.java
3 files changed, 11 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/90/20990/1
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java
index c360f70..9b891d3 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommand.java
@@ -38,18 +38,18 @@
_result = getBroker().getDeviceList(storageType);
proceedProxyReturnValue();
- setReturnValue(ParseLUNList(_result.lunList));
+ setReturnValue(parseLUNList(_result.lunList));
}
- public static ArrayList<LUNs> ParseLUNList(Map<String, Object>[] lunList) {
+ public static ArrayList<LUNs> parseLUNList(Map<String, Object>[] lunList) {
ArrayList<LUNs> result = new ArrayList<LUNs>(lunList.length);
for (Map<String, Object> xlun : lunList) {
- result.add(ParseLunFromXmlRpc(xlun));
+ result.add(parseLunFromXmlRpc(xlun));
}
return result;
}
- public static LUNs ParseLunFromXmlRpc(Map<String, Object> xlun) {
+ public static LUNs parseLunFromXmlRpc(Map<String, Object> xlun) {
LUNs lun = new LUNs();
if (xlun.containsKey("GUID")) {
lun.setLUN_id(xlun.get("GUID").toString());
@@ -105,7 +105,7 @@
pathList[i] = (Map<String, Object>) temp[i];
}
for (Map xcon : pathList) {
- lun.getLunConnections().add(ParseConnection(xcon));
+ lun.getLunConnections().add(parseConnection(xcon));
}
}
}
@@ -133,7 +133,7 @@
return lun;
}
- public static StorageServerConnections ParseConnection(Map<String, Object>
xcon) {
+ public static StorageServerConnections parseConnection(Map<String, Object>
xcon) {
StorageServerConnections con = new StorageServerConnections();
if (xcon.containsKey("connection")) {
con.setconnection(xcon.get("connection").toString());
diff --git
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVGInfoVDSCommand.java
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVGInfoVDSCommand.java
index 1160f55..25b7e8d 100644
---
a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVGInfoVDSCommand.java
+++
b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVGInfoVDSCommand.java
@@ -25,7 +25,7 @@
pvList[i] = (Map<String, Object>) temp[i];
}
}
- setReturnValue(GetDeviceListVDSCommand.ParseLUNList(pvList));
+ setReturnValue(GetDeviceListVDSCommand.parseLUNList(pvList));
}
@Override
diff --git
a/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommandTest.java
b/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommandTest.java
index eea258f..73946a6 100644
---
a/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommandTest.java
+++
b/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetDeviceListVDSCommandTest.java
@@ -32,7 +32,7 @@
}
/**
- * Test that ParseLunFromXmlRpc parses the {@link
GetDeviceListVDSCommand#DEVTYPE_FIELD} correctly.
+ * Test that parseLunFromXmlRpc parses the {@link
GetDeviceListVDSCommand#DEVTYPE_FIELD} correctly.
*
* @param expectedStorageType
* The storage type expected to return.
@@ -43,7 +43,7 @@
Map<String, Object> xlun = new HashMap<String, Object>();
xlun.put(GetDeviceListVDSCommand.DEVTYPE_FIELD, mockDevtype);
- LUNs lun = GetDeviceListVDSCommand.ParseLunFromXmlRpc(xlun);
+ LUNs lun = GetDeviceListVDSCommand.parseLunFromXmlRpc(xlun);
assertEquals(expectedStorageType, lun.getLunType());
}
@@ -51,7 +51,7 @@
@Test
public void parseLunFromXmlRpcReturnsUnknownForNoField() throws Exception {
Map<String, Object> xlun = new HashMap<String, Object>();
- LUNs lun = GetDeviceListVDSCommand.ParseLunFromXmlRpc(xlun);
+ LUNs lun = GetDeviceListVDSCommand.parseLunFromXmlRpc(xlun);
assertEquals(StorageType.UNKNOWN, lun.getLunType());
}
@@ -79,7 +79,7 @@
xlun.put(GetDeviceListVDSCommand.PATHSTATUS, paths.toArray(new
Map[paths.size()]));
// Parse the XmlRpc
- LUNs lun = GetDeviceListVDSCommand.ParseLunFromXmlRpc(xlun);
+ LUNs lun = GetDeviceListVDSCommand.parseLunFromXmlRpc(xlun);
// Go over the directory
assertEquals("wrong number of paths", numPaths, lun.getPathCount());
--
To view, visit http://gerrit.ovirt.org/20990
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icff34cd6a37ec92681547398839da8b8ce2e66b6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
