Alex Lourie has posted comments on this change.

Change subject: packaging: setup: fix DB detection and owner from previous 
versions
......................................................................


Patch Set 5: Verified+1

(1 comment)

....................................................
File packaging/common_utils.py
Line 1215: 
Line 1216:     return True
Line 1217: 
Line 1218: 
Line 1219: def updateDbOwner(db_dict):
I agree, but that utility is not prepared to work as su postgres. We have a 
strict environment here.
Line 1220:     logging.debug('Updating DB owner')
Line 1221:     _RE_OWNER = re.compile(r'^([\w,.\(\)]+\s+)+OWNER TO 
(?P<owner>\w+).*$')
Line 1222:     out, rc = runPostgresSuCommand(
Line 1223:         command=EXEC_PGDUMP,


-- 
To view, visit http://gerrit.ovirt.org/20154
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2fe256660b233bc682dc22e79cf58d34c546c3a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to