[Engine-patches] Change in ovirt-engine[master]: engine: Fix few eclipse warning

[masayag]

Moti Asayag has uploaded a new change for review.

Change subject: engine: Fix few eclipse warning
......................................................................

engine: Fix few eclipse warning

The AuditLogableBase doesn't implement Serializable, therefore
it doesn't required any serial id.

The serial warning can be removed from CommandBase as well.
And replace the type of CommandBase.validate() which hides the
T defined as a parameter class type on the class signature.

Change-Id: I4c6e80252f0a9d907488be6ede45271c936f5de6
Signed-off-by: Moti Asayag <masa...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
2 files changed, 1 insertion(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/53/20953/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
index aeeb895..22d2efc 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
@@ -102,8 +102,6 @@
 import org.ovirt.engine.core.utils.transaction.TransactionSupport;
 import org.springframework.dao.DataAccessException;
 
-
-@SuppressWarnings("serial")
 public abstract class CommandBase<T extends VdcActionParametersBase> extends 
AuditLogableBase implements
         RollbackHandler, TransactionMethod<Object> {
 
@@ -808,7 +806,7 @@
         return validate(getParameters());
     }
 
-    protected <T> boolean validate(T value) {
+    protected <V> boolean validate(V value) {
         List<String> messages = 
ValidationUtils.validateInputs(getValidationGroups(), value);
         if (!messages.isEmpty()) {
             getReturnValue().getCanDoActionMessages().addAll(messages);
diff --git 
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
 
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
index d9e29ce..4c54157 100644
--- 
a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
+++ 
b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
@@ -52,7 +52,6 @@
 import org.ovirt.engine.core.utils.transaction.TransactionSupport;
 
 public class AuditLogableBase extends TimeoutBase {
-    private static final long serialVersionUID = -4764813076922800727L;
     private Guid mVmId = Guid.Empty;
     private DbUser dbUser;
     private Guid mUserId = Guid.Empty;


-- 
To view, visit http://gerrit.ovirt.org/20953
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c6e80252f0a9d907488be6ede45271c936f5de6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches