Alon Bar-Lev has posted comments on this change.
Change subject: engine : Remove dependency of IdQueryParameters from
GetRoleByIdQuery
......................................................................
Patch Set 7:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetRoleByIdQuery.java
Line 14:
Line 15: @Override
Line 16: protected void executeQueryCommand() {
Line 17:
getQueryReturnValue().setReturnValue(DbFacade.getInstance().getRoleDao().get(
Line 18:
getParameters().<Guid>getParameter(UserRolesVdcParameters.RoleId, Guid.class)));
If I understand correctly... if the UserRolesVdcParameters.RoleId is a template
we should be able to write:
getParameters().getParameter(UserRolesVdcParameters.RoleId)
Line 19: }
Line 20:
--
To view, visit http://gerrit.ovirt.org/20415
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67fb4920f8107575dd26e173456a7edf99c3503f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
