Alon Bar-Lev has posted comments on this change.
Change subject: engine: Add infrastructure code for removal of parameter classes
......................................................................
Patch Set 7:
(2 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VdcParametersMap.java
Line 24: /**
Line 25: * A more type safe way of retrieving the value for the
Line 26: * parameter
Line 27: */
Line 28: public <T> T get(VdcParameter<T> param, Class<T> retType) {
where is the less safe method but simpler?
Line 29: Pair.raiseExceptionIfInvalidReturnType(param.getJavaType(),
retType);
Line 30: T paramValue = (T) paramsMap.get(param);
Line 31: if (paramValue == null) {
Line 32: return null;
Line 90:
Line 91: /**
Line 92: * Used for deserializing parameter classes
Line 93: */
Line 94: public void setParamsList(Collection<Pair> paramsList) {
how can public function can receive parameter with private type?
Line 95: paramsMap = new HashMap<VdcParameter, Object>();
Line 96: for (Pair pair : paramsList) {
Line 97: paramsMap.put(pair.getParameter(), pair.getValue());
Line 98: }
--
To view, visit http://gerrit.ovirt.org/20414
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a0970e492c0eff561888a46b02e47645ff68fc3
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
