Ravi Nori has posted comments on this change.

Change subject: engine : Remove EventSubscriptionParameter
......................................................................


Patch Set 6:

(1 comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/GenericVdcParameter.java
Line 3: import org.ovirt.engine.core.common.businessentities.event_subscriber;
Line 4: import org.ovirt.engine.core.compat.Guid;
Line 5: import org.ovirt.engine.core.compat.Version;
Line 6: 
Line 7: public class GenericVdcParameter {
We are envisioning a scenario where each group maintains its own file. Since 
enums cant extend another class this wont work
Line 8: 
Line 9:     public final static VdcParameter GUID_ID = 
VdcParameter.<Guid>create("GUID_ID", Guid.class, new 
Guid("00000000-0000-0000-0000-000000000001"));
Line 10:     public final static VdcParameter Version = 
VdcParameter.<Version>create("Version", Version.class, new 
Guid("00000000-0000-0000-0000-000000000003"));
Line 11:     public final static VdcParameter DomainName = 
VdcParameter.<String>create("DomainName", String.class, new 
Guid("00000000-0000-0000-0000-000000000004"));


-- 
To view, visit http://gerrit.ovirt.org/20417
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e944568ac9395a141cfab3ef4d4304d1ef2d1af
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to