Alon Bar-Lev has posted comments on this change.

Change subject: core: [db] change db owner check from 'engine'
......................................................................


Patch Set 3:

(1 comment)

I cannot really review... :(

....................................................
File packaging/dbscripts/materialized_views_sp.sql
Line 76:      IF FOUND THEN
Line 77:          RAISE EXCEPTION 'Materialized view % already exists.',
Line 78:            v_matview;
Line 79:      END IF;
Line 80:      IF current_user != usename from pg_database , pg_user where 
datdba=usesysid and datname=current_database THEN
I do not know where usename is coming from :))
Line 81:          RAISE EXCEPTION 'Materialized view % should be created with 
user ''engine''.',
Line 82:            v_matview;
Line 83:      END IF;
Line 84: 


-- 
To view, visit http://gerrit.ovirt.org/20778
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e9af94450c8f5a809c34a22ebe36d7a69d3e865
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to