Mike Kolesnik has posted comments on this change.
Change subject: engine: Report unsupported vnic profile features used by vnics
......................................................................
Patch Set 4:
(1 comment)
Basically +2, just a small comment which i think makes sense
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java
Line 564:
Line 565: struct.put(VdsProperties.NETWORK, networkName);
Line 566:
Line 567: if (!addPortMirroringToVmInterface(struct, vnicProfile,
vm.getVdsGroupCompatibilityVersion(),
Line 568: network == null ? Collections.<String> emptyList() :
Collections.singletonList(networkName))) {
This logic should be inside addPortMirroringToVmInterface
Line 569:
unsupportedFeatures.add(VNIC_PROFILE_PROPERTIES.PORT_MIRRORING);
Line 570: }
Line 571:
Line 572: if (!addCustomPropertiesForDevice(struct,
--
To view, visit http://gerrit.ovirt.org/20909
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98f621a64684deb8a19e0657c8268788b0fda275
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
