Michael Pasternak has posted comments on this change.
Change subject: rest: use engine query for CPU caps parsing
......................................................................
Patch Set 3:
(1 comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
Line 184: version.setCpus(new CPUs());
Line 185: List<ServerCpu> cpus =
Line 186: getEntity(List.class,
VdcQueryType.GetAllServerCpuList,
Line 187: new GetAllServerCpuListParameters(new
org.ovirt.engine.core.compat.Version(asString(v))),
Line 188: "List<ServerCpu>");
1. please consider having this code in the old getServerCpuList(Version
version) method
2. please address tests comments from the previous path set
thanks.
Line 189: for (ServerCpu sc : cpus) {
Line 190: CPU cpu = new CPU();
Line 191: cpu.setId(sc.getCpuName());
Line 192: cpu.setLevel(sc.getLevel());
--
To view, visit http://gerrit.ovirt.org/20610
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I768f444f4ac6e5ee37ccba191d0588f00b8e3a44
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa
<[email protected]>
Gerrit-Reviewer: Leonardo Bianconi <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Vitor de Lima <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
