Gilad Chaplik has posted comments on this change.

Change subject: gluster : In the bricks sub-tab for a server, sort the bricks
......................................................................


Patch Set 5:

(1 comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterBrickEntity.java
Line 22:  *
Line 23:  * @see GlusterVolumeEntity
Line 24:  * @see GlusterBrickStatus
Line 25:  */
Line 26: public class GlusterBrickEntity extends IVdcQueryable implements 
BusinessEntityWithStatus<Guid, GlusterStatus>, GlusterTaskSupport, 
Comparator<GlusterBrickEntity>, Serializable{
Since it's a UI sort for a specific field, we usually don't change the BE. see 
examples in Linq.java for Comparator implementations.
Line 27:     private static final long serialVersionUID = 7119439284741452278L;
Line 28: 
Line 29:     @NotNull(message = "VALIDATION.GLUSTER.BRICK.ID.NOT_NULL", groups 
= { RemoveBrick.class })
Line 30:     private Guid id;


-- 
To view, visit http://gerrit.ovirt.org/20781
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifeecb7bb6d020c21167801573bb733aace7e7d9f
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to