Lior Vernia has posted comments on this change. Change subject: webadmin: VnicProfilesEditor to inherit AddRemoveRowWidget ......................................................................
Patch Set 2: (1 comment) .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/vnicProfile/VnicProfileWidget.java Line 102: public void onKeyPress(KeyPressEvent event) { Line 103: Scheduler.get().scheduleDeferred(new ScheduledCommand() { Line 104: @Override Line 105: public void execute() { Line 106: ValueChangeEvent.fire(nameEditor.asValueBox(), nameEditor.asValueBox().getValue()); Exactly. The second handler would have to be there anyway, the first one is to capture every key press as a ValueChangeEvent (instead of only when user focuses out of the widget). Line 107: } Line 108: }); Line 109: } Line 110: }); -- To view, visit http://gerrit.ovirt.org/20492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If66c23bddada57fbfd95292dc2cc1f6c8d9df19e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches