Doron Fediuck has posted comments on this change.

Change subject: core: support pin-to-any
......................................................................


Patch Set 1:

(1 comment)

Hmmm... See inline.

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/PinToHostPolicyUnit.java
Line 21:     @Override
Line 22:     public List<VDS> filter(List<VDS> hosts, VM vm, Map<String, 
String> parameters, List<String> messages) {
Line 23:         // allow Pin-To-Any: if the vm isn't running, and doesn't 
specify any host to be
Line 24:         // pinned, allow to select all hosts.
Line 25:         if (vm.getRunOnVds() == null && vm.getDedicatedVmForVds() == 
null) {
If you're not testing vm.getMigrationSupport() here, you'll always skip pin to 
host functionality.
Line 26:             return hosts;
Line 27:         }
Line 28:         if (vm.getMigrationSupport() == 
MigrationSupport.PINNED_TO_HOST) {
Line 29:             for (VDS host : hosts) {


-- 
To view, visit http://gerrit.ovirt.org/20829
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10d60bb9db2506a63a19f5e75446ddac32b8dc3e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to