Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: update libvirt configuration
......................................................................
Patch Set 1:
(3 comments)
....................................................
File src/plugins/ovirt-hosted-engine-setup/system/vdsmenv.py
Line 126: self.command.get('vdsm-tool'),
Line 127: 'is-configured',
Line 128: '--module libvirt',
Line 129: ),
Line 130: raiseOnError=False,
no need...
Line 131: )
Line 132: if rc != 0:
Line 133: self.execute(
Line 134: (
Line 134: (
Line 135: self.command.get('vdsm-tool'),
Line 136: 'configure',
Line 137: '--module libvirt',
Line 138: '--force',
'--module=libvirt', or '--module', 'libvirt',
Line 139: )
Line 140: )
Line 141: rc, _stdout, _stderr = self.execute(
Line 142: (
Line 141: rc, _stdout, _stderr = self.execute(
Line 142: (
Line 143: self.command.get('vdsm-tool'),
Line 144: 'is-configured',
Line 145: '--module libvirt',
we do not need this.
Line 146: )
Line 147: )
Line 148: if rc != 0:
Line 149: raise RuntimeError(
--
To view, visit http://gerrit.ovirt.org/20868
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I735111e33dd7435067854ec7694b137f4bc62da2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
