Lior Vernia has posted comments on this change. Change subject: webadmin: radiobutton text is truncated & unaligned ......................................................................
Patch Set 2: (1 comment) .................................................... File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java Line 277: migrateOnErrorOption_NOEditor.addContentWidgetStyleName(style.label()); Line 278: migrateOnErrorOption_YESEditor.addContentWidgetStyleName(style.label()); Line 279: migrateOnErrorOption_HA_ONLYEditor.addContentWidgetStyleName(style.label()); Line 280: Line 281: optimizationNoneEditor.setContentWidgetStyleName(style.radioButtonPositioning()); I think the spacing between rows of the same radio button also increased, and not just the spacing between different radio buttons, which as I understand wasn't Einav's intention. Maybe it would be better to set the style of the entire widget? Also, doesn't removing the fullWidth style cause any trouble? Line 282: optimizationForServerEditor.setContentWidgetStyleName(style.radioButtonPositioning()); Line 283: optimizationForDesktopEditor.setContentWidgetStyleName(style.radioButtonPositioning()); Line 284: optimizationCustomEditor.setContentWidgetStyleName(style.radioButtonPositioning()); Line 285: -- To view, visit http://gerrit.ovirt.org/20580 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bd4ef709ada858140cd33d909aed3dc3171f6df Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
