Omer Frenkel has posted comments on this change.
Change subject: core: Detect host in idle prep for maintenance and re-migrate
......................................................................
Patch Set 19:
(5 comments)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 56: public class VdsManager {
Line 57: private VDS _vds;
Line 58: private long lastUpdate;
Line 59: private long updateStartTime;
Line 60: private long nextMaintenanceAtteptTime;
typo *Attempt
Line 61:
Line 62: private static Log log = LogFactory.getLog(VdsManager.class);
Line 63: private volatile long statusChangedTime;
Line 64:
Line 59: private long updateStartTime;
Line 60: private long nextMaintenanceAtteptTime;
Line 61:
Line 62: private static Log log = LogFactory.getLog(VdsManager.class);
Line 63: private volatile long statusChangedTime;
can be removed
Line 64:
Line 65: public boolean getRefreshStatistics() {
Line 66: return (_refreshIteration == _numberRefreshesBeforeSave);
Line 67: }
Line 751: }
Line 752:
Line 753: public void setNextMaintenanceAtteptTime() {
Line 754: this.nextMaintenanceAtteptTime = System.currentTimeMillis() +
TimeUnit.MILLISECONDS.convert(
Line 755:
Config.<Integer>GetValue(ConfigValues.HostPreparingForMaintenanceIdleTime),
TimeUnit.SECONDS);;
double ;;
Line 756: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
Line 1871: } else {
Line 1872: long now = System.currentTimeMillis();
Line 1873: long idleTime = now -
_vdsManager.getStatusChangedTime();
Line 1874: long maxIdleTime = TimeUnit.MILLISECONDS.convert(
Line 1875:
Config.<Integer>GetValue(ConfigValues.HostPreparingForMaintenanceIdleTime),
TimeUnit.SECONDS);
all new code above not needed anymore
Line 1876:
Line 1877: if (idleTime > maxIdleTime && now >
_vdsManager.getNextMaintenanceAtteptTime()) {
Line 1878:
ResourceManager.getInstance().getEventListener().handleVdsMaintenanceTimeout(_vds);
Line 1879: _vdsManager.setNextMaintenanceAtteptTime();
....................................................
File packaging/etc/engine-config/engine-config.properties
Line 341: ExternalSchedulerResponseTimeout.type=Integer
Line 342: DwhHeartBeatInterval.description="Interval after which DWH is
informed that engine is running (in seconds)"
Line 343: DwhHeartBeatInterval.type=Integer
Line 344: HostPreparingForMaintenanceIdleTime.type=Integer
Line 345: HostPreparingForMaintenanceIdleTime.description="Time to wait in
seconds to determine if host is idling in status PreparingForMaintenace. When
that interval is met it triggers another attempt to move the host to
Maintenance"
please remove white space
--
To view, visit http://gerrit.ovirt.org/17942
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e18bcfbc566b6fd92d276c5c739ba607e2a53f0
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
