Allon Mureinik has posted comments on this change. Change subject: engine: Disk interface validation ......................................................................
Patch Set 7: (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java Line 46: import org.ovirt.engine.core.common.businessentities.permissions; Line 47: import org.ovirt.engine.core.common.config.Config; Line 48: import org.ovirt.engine.core.common.config.ConfigValues; Line 49: import org.ovirt.engine.core.common.errors.VdcBllMessages; Line 50: import org.ovirt.engine.core.common.locks.LockingGroup; Looks OK to me. Roy, can you clarify what you're referring to? Line 51: import org.ovirt.engine.core.common.utils.Pair; Line 52: import org.ovirt.engine.core.common.utils.VmDeviceType; Line 53: import org.ovirt.engine.core.common.validation.group.UpdateEntity; Line 54: import org.ovirt.engine.core.compat.Guid; -- To view, visit http://gerrit.ovirt.org/18648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe095557089aa5670c50eaa120eac9f60e13aea0 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
