Allon Mureinik has posted comments on this change.
Change subject: host-deploy: add Closeable interface to our objects
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
Line 872: try {
Line 873: _control.close();
Line 874: }
Line 875: catch (IOException ee) {
Line 876: log.error("Error during close", e);
oof :-(
Yeah, good point.
You can always specify that that VdsDeploy.close() does NOT throw that
exception (allowed - sub classes can be more strict than their parents), but...
ichs.
lets leave it like this.
Line 877: }
Line 878: }
Line 879: }
Line 880:
--
To view, visit http://gerrit.ovirt.org/20796
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae58c623eb1f3acabe2404022b9bdbae32095bbb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
