Daniel Erez has posted comments on this change. Change subject: core, engine: Limit the number of SCSI and VirtIO blk devices ......................................................................
Patch Set 2: (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java Line 106: // 3 IDE slots: 4 total minus 1 for CD Line 107: public final static int MAX_IDE_SLOTS = 3; Line 108: // The maximum number of VirtIO SCSI disks that libvirt Line 109: // allows without creating another controller Line 110: public final static int MAX_VIRTIO_SCSI_DISKS = 6; Where did you get this number from? A controller should support up to 256 disks (otherwise, it's an issue in libvirt that should be handled...) Line 111: // The maximum number of sPAPR VSCSI disks that Line 112: // can be detected by the Linux kernel of PPC64 guests Line 113: public final static int MAX_SPAPR_SCSI_DISKS = 8; Line 114: -- To view, visit http://gerrit.ovirt.org/20630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd923ca7b48b65f700a1c7cf6d0d938f12ebe48c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
