Roy Golan has posted comments on this change.
Change subject: core: fix issue with search on OSs
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
Line 3065: public void onSuccess(Object model, Object returnValue) {
Line 3066: uniqueOsNames = (HashMap<Integer, String>)
((VdcQueryReturnValue) returnValue).getReturnValue();
Line 3067: // Initialize specific UI dependencies for search
Line 3068: SimpleDependecyInjector.getInstance().bind(new
OsValueAutoCompleter(uniqueOsNames));
Line 3069: }
correct and because its async and you let the callback do the job you cannot
have your dependencies lay on it. thats why I moved the init of the search
dependecies to the callback directly, to eagerly load it.
loading UI dependecies async is wrong and the api to query the backend should
contain a direct call. not part of the Frontend.java while it should.
Line 3070: };
Line 3071: Frontend.RunQuery(VdcQueryType.OsRepository, new
OsQueryParameters(OsRepositoryVerb.GetUniqueOsNames), callback);
Line 3072: }
Line 3073:
--
To view, visit http://gerrit.ovirt.org/20743
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9434189173939ba595862a40483d8da5107228b2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.3
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
