Liran Zelkha has posted comments on this change. Change subject: restapi: Add external id to users and groups ......................................................................
Patch Set 6: Code-Review+1 (1 comment) .................................................... File backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd Line 1555: <xs:complexContent> Line 1556: <xs:extension base="BaseResource"> Line 1557: <xs:sequence> Line 1558: <xs:element ref="domain" minOccurs="0"/> Line 1559: <xs:element name="external_id" type="xs:hexBinary" minOccurs="0" maxOccurs="1"/> What's our versioning policy concerning NBI and schema? Shouldn't we point out that this is a new version of the user object? Line 1560: <xs:element name="department" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 1561: <xs:element name="logged_in" type="xs:boolean" minOccurs="0" maxOccurs="1"/> Line 1562: <xs:element name="last_name" type="xs:string" minOccurs="0" maxOccurs="1"/> Line 1563: <!-- generally name@domain --> -- To view, visit http://gerrit.ovirt.org/19478 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I799219080a57c6ec4ef0e16c742f1f44d11f1080 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Liran Zelkha <liran.zel...@gmail.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
