Maor Lipchuk has posted comments on this change. Change subject: core: export vm - removal of unneeded for loop ......................................................................
Patch Set 2: Code-Review+2 (1 comment) .................................................... Commit Message Line 8: Line 9: All the disks that are part of the export are already being iterated Line 10: over, their id's can be added during that loop. Line 11: Furthermore, there's no need to include id's that aren't part of the Line 12: export (of shareable/snapshot disks). please remove snapshot disks Line 13: Line 14: Change-Id: I8f6c3b2ae192674e7edc86840253d6f8ef02d5c0 -- To view, visit http://gerrit.ovirt.org/20710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f6c3b2ae192674e7edc86840253d6f8ef02d5c0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
