Martin Sivák has posted comments on this change.

Change subject: core: Log filtering progress in scheduling
......................................................................


Patch Set 11:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java
Line 415:         return null;
Line 416:     }
Line 417: 
Line 418:     private void logFilterActions(List<VDS> oldList,
Line 419:             List<Guid> newList,
Can we change the newList to Collection<Guid> and use Set<Guid> as the return 
value of toIdList?
Line 420:             VdcBllMessages actionName,
Line 421:             String filterName,
Line 422:             SchedulingResult result,
Line 423:             String correlationId) {


-- 
To view, visit http://gerrit.ovirt.org/19213
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4edcc33b0d280ab92e3c98d8d5a7a75386592e32
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Martin Sivák <msi...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to