Daniel Erez has posted comments on this change. Change subject: webadmin: Improve UI Plugin data reload logic ......................................................................
Patch Set 1: Code-Review+2 (1 comment) .................................................... File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/plugin/PluginDataManager.java Line 160: reloadDescriptor = descriptorLastModified > currentData.getDescriptorLastModified(); Line 161: reloadConfiguration = configurationLastModified > currentData.getConfigurationLastModified(); Line 162: Line 163: // Change in descriptor causes reload of configuration Line 164: reloadConfiguration = reloadConfiguration || reloadDescriptor; Just a nitpick, maybe worth using the "|=" operator in the following statements [just a matter of taste of course ;)] Line 165: Line 166: // Refresh configuration if the corresponding file has gone missing Line 167: reloadConfiguration = reloadConfiguration || (configurationLastModified == MISSING_FILE_LAST_MODIFIED Line 168: && currentData.getConfigurationLastModified() != MISSING_FILE_LAST_MODIFIED); -- To view, visit http://gerrit.ovirt.org/20522 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibefec7f4a5748b89e762b88eafed044fab977d04 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
