Sandro Bonazzola has posted comments on this change.
Change subject: packaging: changed the db dict get method
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
....................................................
File packaging/ovirt-engine-reports-setup.py
Line 264: 'dbname': (
Line 265: dhandler.getParam('REPORTS_DATABASE') or
Line 266: JRS_DB_NAME
Line 267: ),
Line 268: 'host': handler.getParam('ENGINE_DB_HOST').replace('"',
''),
please use .strip('"') instead of replace.
Line 269: 'port': handler.getParam('ENGINE_DB_PORT').replace('"',
''),
Line 270: 'username': (
Line 271: dhandler.getParam('REPORTS_USER') or
Line 272: REPORTS_DB_USER
--
To view, visit http://gerrit.ovirt.org/20701
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I72e386787f7b074f365506dedb9976fed2554dc4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
