Sandro Bonazzola has posted comments on this change.
Change subject: packaging: changed the db dict get method
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
....................................................
File packaging/ovirt-engine-dwh-setup.py
Line 218: 'dbname': (
Line 219: dhandler.getParam('DWH_DATABASE') or
Line 220: DB_NAME
Line 221: ),
Line 222: 'host': handler.getParam('ENGINE_DB_HOST').replace('"',
''),
please use .strip('"') instead of replace. I'm not sure it is possible have "
escaped around in these variables but we want to remove only heading and
trailing '"'
Line 223: 'port': handler.getParam('ENGINE_DB_PORT').replace('"',
''),
Line 224: 'username': (
Line 225: dhandler.getParam('DWH_USER') or
Line 226: DB_USER
--
To view, visit http://gerrit.ovirt.org/20700
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68b69296bffd98c7262751bc807da54885791b28
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
