Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: refactoring ......................................................................
Patch Set 3: > > Did you check how this nesting affects the logs? > it seems that the nesting directory is transparent to the logs: > otopi.plugins.ovirt_engine_setup.all-in-one.storage.Plugin._init > where the file is: > > /usr/share/ovirt-engine/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/storage.py > so if the ordering is done at method level and not at file level, anything > should be changed. OK, this is not good. We want the full path to be both in the log and in the method name. Consider: plugins/ovirt-engine-setup/base/core/something.py plugins/ovirt-engine-setup/ovirt-engine/core/something.py We need to be able which 'something.py' was called when. -- To view, visit http://gerrit.ovirt.org/20293 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I572da9cd7b4a2b9e1fdfee4c05e83a0ca31b99bc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
