Liron Ar has posted comments on this change.
Change subject: core: don't skip storagePoolStatusChange call
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java
Line 591: // If VDS is in initialize status, wait for it to be up
(or until
Line 592: // configurable timeout is reached)
Line 593: waitForVdsIfIsInitializing(curVdsId);
Line 594: // update pool status to problematic while selecting spm
Line 595: try {
there are issues here
1. in the scenario of the bug, the domain status will change over and over
between Unknown/Active because this will set it to be unknown while the domain
monitoring of the host that does see it will move it to active.
We should perform it only when the prev status != non responsive (old
condition) or when there is no applicable host to be spm (List<VDS>
prioritizedVdsInPool is empty) - otherwise the domain should move "alone" to
it's correct status as we have monitoring by one host alteast.
2. In SetStoragePoolStatusCommand there are many operations that should be
unneeded if the pool status is arleady non responsive, synchronized blocks,
etc..need to be eliminated after that change.
Line 596: ResourceManager
Line 597: .getInstance()
Line 598: .getEventListener()
Line 599: .storagePoolStatusChange(_storagePoolId,
StoragePoolStatus.NonResponsive,
--
To view, visit http://gerrit.ovirt.org/20527
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37741911c8e22f7534516d3ed8bccca6b311dc92
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Liron Ar <lara...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
